kola: run provisioning tests separately #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This effectively upstreams coreos/fedora-coreos-pipeline@c3af4ad57ab4. The same reasons apply, but we're doing it now here too because it'll help with not hitting against our memory limits.
jlebon
requested review from
ravanelli,
mike-nguyen,
saqibali-2k,
gursewak1997 and
dustymabe
as code owners
This was referenced Oct 12, 2022
|
I bet we could revert this (and the pipeline version) once we have coreos/coreos-assembler#3118. Because that'll naturally lower the concurrency on these tests. Though if it still causes issues, we should lower this into kola in the form of a e.g. |
|
Ah, nice, thanks for digging into this. I think coreos/coreos-assembler#3118 is the best fix, but even short term, this also touches on coreos/coreos-assembler#3008 and the need to be able to implement logic like this that's decoupled from Jenkins. |
jlebon
added a commit
to jlebon/coreos-ci-lib
that referenced
this pull request
Oct 13, 2022
Some upstreams just want to run a subset of tests. coreos#118 split out the reprovisioning tests, but it then changed the semantics for users that only want to run a specific pattern. Now, those CIs are always running reprovisioning tests even though they're not interested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This effectively upstreams
coreos/fedora-coreos-pipeline@c3af4ad57ab4.
The same reasons apply, but we're doing it now here too because it'll help with not hitting against our memory limits.