Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/kola: disable yum repos for kernel-replace test #3338

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

dustymabe
Copy link
Member

Even though all the rpms that we are replacing are local rpm-ostree
will still reach out to the repos during the operation. Let's just
disable all the repos to prevent this from happening.

This was causing issues in our RHCOS pipeline because we have more
strict egress rules there and it was trying to hit the CentOS mirrors
when testing on c9s since the yum repos are there in c9s by default.

xref: openshift/os#1673


also a second commit in there to fix a copy/paste error from 6f86533

This is done elsewhere in this file and was a copy/paste error
during 6f86533.
Even though all the rpms that we are replacing are local rpm-ostree
will still reach out to the repos during the operation. Let's just
disable all the repos to prevent this from happening.

This was causing issues in our RHCOS pipeline because we have more
strict egress rules there and it was trying to hit the CentOS mirrors
when testing on c9s since the yum repos are there in c9s by default.

xref: openshift/os#1673
Copy link
Member

@marmijo marmijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe dustymabe enabled auto-merge (rebase) January 29, 2025 00:42
@dustymabe dustymabe merged commit 9954445 into coreos:testing-devel Jan 29, 2025
3 checks passed
@dustymabe dustymabe deleted the dusty-disable-yum-repos branch January 29, 2025 01:07
Copy link
Member

@c4rt0 c4rt0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took me a while to wrap my head around this.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants