Skip to content

Commit

Permalink
CI check for release notes YAML doc
Browse files Browse the repository at this point in the history
This is a CI check for the release notes of next.yml, stable.yml and
testing.yml to catch the syntax and schema errors in these files.

Ref: #628
  • Loading branch information
aaradhak committed Aug 6, 2024
1 parent c3f3499 commit 8b4a2f1
Show file tree
Hide file tree
Showing 2 changed files with 117 additions and 0 deletions.
17 changes: 17 additions & 0 deletions .github/workflows/validate-release-notes.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
name: Validate Release Notes

on:
pull_request:
branches: [main]
paths: ["release-notes/*.yml"]

jobs:
validate:
name: Validate Release Notes
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v2

- name: Validate Release Notes
run: python ci/check-release-notes.py release-notes/next.yml release-notes/stable.yml release-notes/testing.yml
100 changes: 100 additions & 0 deletions ci/check-release-notes.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,100 @@
#!/usr/bin/python3

import argparse
import yaml
import re
import sys

def validate_release_notes_structure(data, file_name):
valid = True

if not isinstance(data, dict):
print(f"Error: YAML root should be a dictionary in {file_name}.")
valid = False

if 'releases' not in data:
print(f"Error: 'releases' key not found in {file_name}.")
valid = False

if not isinstance(data.get('releases'), dict):
print(f"Error: 'releases' key should contain a dictionary in {file_name}.")
valid = False

for release, content in data.get('releases', {}).items():
if not re.match(r'^\d+\.\d{8}\.\d+\.\d+$', release):
print(f"Error: Release key '{release}' should follow the pattern 'x.yyyymmdd.n.m' in {file_name}.")
valid = False

release_line = f"{release}:"
if not release_line.endswith(':'):
print(f"Error: Release key '{release}' does not end with a colon ':' in {file_name}.")
valid = False

if not isinstance(content, dict):
print(f"Error: Release {release} should contain a dictionary in {file_name}.")
valid = False

if 'issues' not in content:
print(f"Error: 'issues' key not found for release {release} in {file_name}.")
valid = False

if not isinstance(content.get('issues'), list):
print(f"Error: 'issues' key for release {release} should contain a list in {file_name}.")
valid = False

for issue in content.get('issues', []):
if not isinstance(issue, dict):
print(f"Error: Each issue for release {release} should be a dictionary in {file_name}.")
valid = False

if 'text' not in issue:
print(f"Error: 'text' key not found in issue for release {release} in {file_name}.")
valid = False
if 'url' not in issue:
print(f"Error: 'url' key not found in issue for release {release} in {file_name}.")
valid = False

return valid

def validate_indentation(file_path):
valid = True
with open(file_path, 'r') as file:
lines = file.readlines()

indent_size = 2
for i, line in enumerate(lines):
stripped_line = line.lstrip()
if stripped_line and (len(line) - len(stripped_line)) % indent_size != 0:
print(f"Error: Incorrect indentation at line {i + 1} in {file_path}: '{line.strip()}'")
valid = False
return valid

def main():
parser = argparse.ArgumentParser(description='Validate release notes YAML files.')
parser.add_argument('paths', nargs='+', help='paths to YAML files')
args = parser.parse_args()

all_valid = True

for yaml_file in args.paths:
try:
with open(yaml_file, 'r') as file:
data = yaml.safe_load(file)
except Exception as e:
print(f"Error loading YAML file {yaml_file}: {e}")
all_valid = False
continue

if not validate_release_notes_structure(data, yaml_file):
all_valid = False

if not validate_indentation(yaml_file):
all_valid = False

if all_valid:
print("Validation successful for all files.")
else:
sys.exit(1)

if __name__ == "__main__":
main()

0 comments on commit 8b4a2f1

Please sign in to comment.