Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-notes: updates for the 20240730 releases #936

Closed
wants to merge 1 commit into from

Conversation

marmijo
Copy link
Member

@marmijo marmijo commented Aug 8, 2024

NOTE: there are syntax errors in the initial push to test #934

EDIT: Syntax errors have been corrected

@marmijo
Copy link
Member Author

marmijo commented Aug 8, 2024

Nice! Great job on #934 @aaradhak

Error loading YAML file: mapping values are not allowed here
  in "release-notes/next.yml", line 3, column 11
Validating release-notes/stable.yml...
Validating release-notes/testing.yml...
Error: 'issues' key for release 40.20240[7](https://github.com/coreos/fedora-coreos-streams/actions/runs/10308721273/job/28536791362?pr=936#step:3:8)28.2.1 should contain a list.
Traceback (most recent call last):
  File "/home/runner/work/fedora-coreos-streams/fedora-coreos-streams/ci/check-release-notes.py", line [8](https://github.com/coreos/fedora-coreos-streams/actions/runs/10308721273/job/28536791362?pr=936#step:3:9)4, in <module>
    main()
  File "/home/runner/work/fedora-coreos-streams/fedora-coreos-streams/ci/check-release-notes.py", line 75, in main
    if not validate_release_notes_structure(data):
  File "/home/runner/work/fedora-coreos-streams/fedora-coreos-streams/ci/check-release-notes.py", line 43, in validate_release_notes_structure
    for issue in content.get('issues', []):
TypeError: 'NoneType' object is not iterable

due to no colon here:

40.20240728.1.1
issues: []

and no list (brackets) here:

40.20240728.2.1:
issues:

@marmijo marmijo force-pushed the release-notes-20240808 branch from fe6b4a1 to eef594d Compare August 8, 2024 20:07
@marmijo
Copy link
Member Author

marmijo commented Sep 6, 2024

closing in favor of #946

@marmijo marmijo closed this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants