-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add azure blob support #1923
base: main
Are you sure you want to change the base?
Add azure blob support #1923
Conversation
Still needs to be tested, working through that atm. |
0b8dda6
to
86ec426
Compare
c94adc9
to
c14396b
Compare
I have tested this and it does work! yay; Alright; outstanding things; Obviously need to rebase and fix conflicts ✅ Need to add documentation, and I started here on this documentation; was thinking about examples.md but after thinking about it I dont think that makes any sense, there is no sig change and it would work from the point of remote-ign files. Was thinking about breaking out the parse logic for url into a func just for unit testing but wdyt? |
c14396b
to
c99df9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question but looks good. The main thing we'll have to look at is if the licenses of the introduced code are compatible with our own.
c99df9d
to
facd177
Compare
use azure sdk to authorize, initiate and fetch ignition config file from azure blob storage. fixes: https://issues.redhat.com/browse/COS-2859
@travier re the licensing I think we are g2g since we are set as Apache v2.0 Both seem to be MIT => |
facd177
to
8251efa
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Separated commits because of the extreme of vendoring.