Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add azure blob support #1923

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

prestist
Copy link
Collaborator

Separated commits because of the extreme of vendoring.

@prestist
Copy link
Collaborator Author

Still needs to be tested, working through that atm.

@prestist
Copy link
Collaborator Author

prestist commented Jan 25, 2025

I have tested this and it does work! yay;

Alright; outstanding things;

Obviously need to rebase and fix conflicts ✅

Need to add documentation, and I started here on this documentation; was thinking about examples.md but after thinking about it I dont think that makes any sense, there is no sig change and it would work from the point of remote-ign files.

Was thinking about breaking out the parse logic for url into a func just for unit testing but wdyt?

@prestist prestist force-pushed the add-azureblob-support branch from c14396b to c99df9d Compare January 25, 2025 01:40
Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question but looks good. The main thing we'll have to look at is if the licenses of the introduced code are compatible with our own.

internal/resource/url.go Outdated Show resolved Hide resolved
@prestist prestist force-pushed the add-azureblob-support branch from c99df9d to facd177 Compare January 28, 2025 18:25
use azure sdk to authorize, initiate and fetch ignition config file from azure blob storage.

fixes: https://issues.redhat.com/browse/COS-2859
@prestist
Copy link
Collaborator Author

prestist commented Jan 28, 2025

@travier re the licensing I think we are g2g since we are set as Apache v2.0

Both seem to be MIT =>
microsoft-authentication-library-for-go
azure-sdk-for-go

@prestist prestist force-pushed the add-azureblob-support branch from facd177 to 8251efa Compare January 28, 2025 18:39
@prestist
Copy link
Collaborator Author

git reset HEAD^
git rebased on upstream/main
go mod tidy
go mod vendor
git add .
git commit -m "vendor: get new dependencies for azure blob support"
git push -f 

Copy link
Contributor

@yasminvalim yasminvalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants