fix(redirect): Validate redirect destination URL schemes#45
Merged
Conversation
Reject javascript, data, and protocol-relative URLs in readDomItemRedirect and performRedirect while allowing relative paths and http(s) links.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds URL scheme validation to the shared redirect helper used by menu, select, listbox, combobox, and tree-view hooks.
If server-rendered data-to / data-value (or a fallback) is user-controlled or tampered with, destinations like javascript:... or //evil.example could trigger script execution or open redirects via window.location.href, window.open, or LiveView patch / navigate.
Changes
assets/lib/redirect.ts
New exported isAllowedRedirectDestination():
Allowed: relative paths (/items, ./x, ?page=2), http:, https:
Blocked: javascript:, data:, vbscript:, protocol-relative //..., and other schemes
readDomItemRedirect() returns null for disallowed destinations (including fallback strings)
performRedirect() returns false without navigating when the destination is disallowed
assets/test/lib/redirect.test.ts
Scheme allowlist unit tests
Regression tests for blocked javascript: and // URLs in DOM parsing and redirect execution
Affected components
Any hook that calls performRedirect / readDomItemRedirect from assets/lib/redirect.ts:
Menu
Select
Listbox
Combobox
Tree view