fix(deps): widen phoenix_live_view to ~> 1.1 for phx.new compatibility#65
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integration tests failed at
mix deps.getbecause the latestphx_newarchive generates apps withphoenix_live_view ~> 1.2.0, while Corex pinned~> 1.1.0. In Mix,~> 1.1.0means>= 1.1.0 and < 1.2.0, so Hex could not satisfy both constraints.This change widens Corex's constraint to
~> 1.1(>= 1.1.0 and < 2.0.0). Generated apps keep whatever LiveView line their Phoenix installer chose: olderphx.newapps on~> 1.1.0resolve to 1.1.x, newer apps on~> 1.2.0resolve to 1.2.x. Corex does not force an upgrade.Updated in:
mix.exse2e/mix.exsintegration_test/mix.exsTest plan
mix deps.getandmix compile --warnings-as-errorsin repo rootmix deps.getine2e/andintegration_test/integration-testsjob passes (code generation +deps.geton generated apps)