fix(menu): sync trigger aria-disabled and tabindex on LiveView patch#67
Open
karim-semmoud wants to merge 2 commits into
Open
fix(menu): sync trigger aria-disabled and tabindex on LiveView patch#67karim-semmoud wants to merge 2 commits into
karim-semmoud wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the follow-up to #61 where toggling
<.menu disabled={...}>correctly patched nativedisabledon the trigger, butaria-disabledandtabindexstayed frozen at their initial SSR values. That broke keyboard navigation when enabling a bulk-actions menu after row selection.Root cause:
aria-disabledandtabindexremain inTrigger.ignored_attrs, so LiveView does not patch them. Hookupdated()already callsmenu.render(), but Zag'sgetTriggerProps()does not emit those attrs, andspreadPropsonly toggled nativedisabled.This change derives
aria-disabledandtabindexfrom the patched nativedisabledattribute during clientrender(), matchingConnect.trigger/1.Will close #59
Changes
assets/components/menu.ts: addtriggerDisabledAttrs/1and spreadaria-disabled+tabindexon the root trigger inrender()assets/test/component/menu.test.ts: cover enable/disable toggle updating a11y attrse2e/test/components/menu_test.exs: playground disabled switch toggles trigger a11y statee2e/test/support/models/menu_model.ex: helpers for trigger enabled/disabled assertionspriv/static/menu.mjs: rebuilt bundleTest plan
pnpm test -- assets/test/component/menu.test.tsmix assets.buildcd e2e && mix test test/components/menu_test.exs:82