Adding a managed type for service_ensure #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to have the metricbeat service created by the module while being able to enable or disable it manually.
This need comes from metricbeat deployment recommandations to monitor an elasticsearch cluster with dedicated master nodes. There should be only one instance of metricbeat running (with scope: cluster) : https://www.elastic.co/guide/en/elasticsearch/reference/current/configuring-metricbeat.html
This PR adds a managed value for service_ensure parameter which let puppet create the service while leaving its state to the os.