Skip to content

Enable memcached by default and fix discovering instances #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 15, 2025

Conversation

friedrichg
Copy link
Member

What this PR does: Switches to clusterIP none so that all instances can be discovered.

Which issue(s) this PR fixes:
Fixes #550

Checklist

  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX], [DEPENDENCY]

@friedrichg friedrichg force-pushed the fix-memcached-discovery branch from 3d57c79 to 1a5710a Compare August 12, 2025 00:46
Signed-off-by: Friedrich Gonzalez <[email protected]>
Copy link
Collaborator

@nschad nschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, small nits.

@nschad
Copy link
Collaborator

nschad commented Aug 12, 2025

Also @friedrichg you guys over at jsonnet use dnssrvnoa I believe for DNS service discovery, while we here use dns. Should we change that?

Signed-off-by: Friedrich Gonzalez <[email protected]>
@nschad nschad requested a review from kd7lxl August 13, 2025 08:02
@nschad nschad merged commit 68bbc4a into master Aug 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

thanos_memcached_dns_provider_results is always 1
2 participants