-
Notifications
You must be signed in to change notification settings - Fork 816
Add cortex_ingester_active_native_histogram_series metric to track ac… #6695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cortex_ingester_active_native_histogram_series metric to track ac… #6695
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems a very nice improvement. @harry671003 Can you help take a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Should we also track native histogram samples separately in distributor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you!
…tive # of NH series Signed-off-by: SungJin1212 <[email protected]>
7aca81c
to
4b42a00
Compare
@harry671003 We could change |
Do you mean we add a dedicated metric for NH? Similar to |
Currently, the metric
cortex_ingester_active_series
tracks the number of active series, including native histogram(NH) and float series. So, we cannot track the number of NH series only.This PR adds a
cortex_ingester_active_native_histogram_series
metric to track only the number of active NH series.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]