Add zone label to ring_members metric. #6900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Le <[email protected]>
alexqyle
changed the title
Signed-off-by: Alex Le <[email protected]>
Signed-off-by: Alex Le <[email protected]>
danielblando
approved these changes
Jul 23, 2025
3 tasks
Signed-off-by: Alex Le <[email protected]>
SungJin1212
approved these changes
Jul 24, 2025
rubywtl
pushed a commit
to rubywtl/cortex
that referenced
this pull request
Jul 28, 2025
* add zone label to ring_members metric Signed-off-by: Alex Le <[email protected]> * update changelog Signed-off-by: Alex Le <[email protected]> * fix nil pointer Signed-off-by: Alex Le <[email protected]> --------- Signed-off-by: Alex Le <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add
zonelabel to metricring_members. So end user could know ring members by state by zone. This would be useful to make sure ring members are balanced across zones.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]