Upgrade metrics dependence and middleware#444
Closed
ppaanngggg wants to merge 1 commit intocortezaproject:2022.9.xfrom
ppaanngggg:2022.9.x-fix-metrics
Closed
Upgrade metrics dependence and middleware#444ppaanngggg wants to merge 1 commit intocortezaproject:2022.9.xfrom ppaanngggg:2022.9.x-fix-metrics
ppaanngggg wants to merge 1 commit intocortezaproject:2022.9.xfrom
ppaanngggg:2022.9.x-fix-metrics
Conversation
Use my fork of chi-prometheus which fix PatternMiddleware bug, upgrade chi to v5 and prometheus to latest. Use NewPatternMiddleware(...) instead of NewMiddleware(...). Disable auth when password is empty.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 2022.9.x #444 +/- ##
===========================================
Coverage ? 40.44%
===========================================
Files ? 836
Lines ? 83340
Branches ? 0
===========================================
Hits ? 33711
Misses ? 44899
Partials ? 4730 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Contributor
|
Great. Let's wait then until they accept the PR. |
vicpatel
force-pushed
the
2022.9.x
branch
4 times, most recently
from
f340da1 to
c759280
Compare
Contributor
Author
It seems like that project has no maintainer now. |
Contributor
|
What can we do here? I'm not in favour of changing the package like this. Is there another, more active fork? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use my fork of chi-prometheus which fix PatternMiddleware bug, upgrade chi to v5 and prometheus to latest. Use NewPatternMiddleware(...) instead of NewMiddleware(...). Disable auth when password is empty.
I open PR to original repo 766b/chi-prometheus#11 now.
And edit code and commit message as
web-console.