Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carter214/6.8.3 #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

carter214
Copy link

Thank you for a great article. I have updated the docker images to the latest 6.x versions. I will try 7.x when I have more time.

Instead of manually restarting the apm-server, I have added a restart policy of always.

Copy link
Owner

@cosminseceleanu cosminseceleanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a proper PR title

@@ -70,8 +70,7 @@ Besides the REST api, the application will have some scheduled backgrounds tasks

![alt-text](./images/docker-ps.png)

If APM Server service doesn't start, it's because it uses Elasticsearch and Elasticsearch take some time to start. To solve this, just restart some containers using this command: `docker-compose -f docker/docker-compose.yml restart apm user-microservice
`.
If APM Server service is restarting, it's because it uses Elasticsearch and Elasticsearch take some time to start. This will resolve itself when Elasticsearch is available.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need this paragraph?

@@ -49,6 +49,7 @@ services:
build:
context: apm-server
dockerfile: Dockerfile
restart: always
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants