Add neutron-carbon ibc #5887
Add neutron-carbon ibc #5887
Conversation
|
@JeremyParish69 hi! may i seek your assistance to look into this PR! |
* Update carbon assetlist and chain config * Add and update token assets * Update IBC connections to carbon * Make some manual corrections to config files
|
Hi @JeremyParish69, I've resolved your comment alr. In addition, I accidentally merged an extra commit with several more changes to our master branch. Please let us know if we should close this PR and create a new one to better reflect the changes. Apologies for the inconvenience! 🙏 |
| "base_denom": "wei" | ||
| }, | ||
| "provider": "PolyNetwork" | ||
| "provider": "Axelar Bridge" |
There was a problem hiding this comment.
I'm suspicious of this actually being via Axelar. Their API shows a different base denom (as ibc/...) for these assets, not starting with (brdg/). Are we sure that isn't a typo?
There was a problem hiding this comment.
this is a asset starting with brdg
There was a problem hiding this comment.
Ok, but why does it say Axelar here?
| ] | ||
| } | ||
| ], | ||
| "base": "bnb.1.6.773edb", |
There was a problem hiding this comment.
It looks like you may be removing this base_denom? Instead of removing, please mark as "deprecated": true. you may update the name of symbol to avoid confusion with the replacement BNB). Same idea applies to all assets being removed
carbon/assetlist.json
Outdated
| "base_denom": "USD" | ||
| }, | ||
| "provider": "PolyNetwork" | ||
| "provider": "Tether" |
There was a problem hiding this comment.
It doesn't appear that Tether is issuing USDt here. Are there any docs from them that show this as one of their issuances?
There was a problem hiding this comment.
This synthetic asset comprises of usdt bridged in from other chains via axelar. These assets are those that are listed on https://tether.to/en/supported-protocols. Would there be a more appropriate provider that i could change to?
There was a problem hiding this comment.
The Provider should be the team that creates the synthetic token itself--not who issued the token it follows, nor who provides the backing/collateral. Who is it that is creating this synthetic token? Is it Carbon or Demex?
There was a problem hiding this comment.
got it. i amended all synthetic tokens to carbon as the provider as it is created by carbon.
carbon/assetlist.json
Outdated
| "chain_name": "binancesmartchain", | ||
| "base_denom": "0xe9e7cea3dedca5984780bafc599bd69add087d56" | ||
| }, | ||
| "provider": "Axelar Bridge" |
There was a problem hiding this comment.
Still suspicious of this provider...
There was a problem hiding this comment.
this should be Binance taking reference from their assetlist.
| }, | ||
| { | ||
| "denom": "busd.1.6.754a80", | ||
| "denom": "brdg/1768794901f8a19c2ec795a5402653cef6cbfe6b3ec6398d39fc37de963cb667", |
There was a problem hiding this comment.
From verification script output:
Error: Chain carbon does not have fee token brdg/1768794901f8a19c2ec795a5402653cef6cbfe6b3ec6398d39fc37de963cb667 defined in its Assetlist.
There was a problem hiding this comment.
hi i have addressed this and add more that were found to be missing as well
| } | ||
| }, | ||
| { | ||
| "denom": "ibc/2B9D089E73AC096934CD6BBBC71A1CD5DD2A4F8E94CC37CE7F861AC674044002", |
There was a problem hiding this comment.
Error: Chain carbon does not have fee token ibc/2B9D089E73AC096934CD6BBBC71A1CD5DD2A4F8E94CC37CE7F861AC674044002 defined in its Assetlist.
There was a problem hiding this comment.
added all fee tokens that are missing
There was a problem hiding this comment.
No, this one is still missing (and possibly others)
carbon/assetlist.json
Outdated
| "type": "bridge", | ||
| "counterparty": { | ||
| "chain_name": "binancesmartchain", | ||
| "base_denom": "0xe9e7cea3dedca5984780bafc599bd69add087d56" |
There was a problem hiding this comment.
Error: Trace of carbon, brdg/452281b506e82a21c2eedfd593d30883848ddec29cd5747e8e80720cc14e8b84 makes invalid reference to binancesmartchain, 0xe9e7cea3dedca5984780bafc599bd69add087d56.
The referenced asset is registered, but this isn't using the correct letter-casing (0xe9e7CEA3DedcA5984780Bafc599bD69ADd087D56)
There was a problem hiding this comment.
Fixed. How can i check if there are more like this ?
There was a problem hiding this comment.
In your fork Switcheo:master, you can run the Action Data Validation PR Workflow via GitHub or run node validate_data.mjs if done locally.
carbon/assetlist.json
Outdated
| "chain_name": "arbitrum", | ||
| "base_denom": "0xab19bdaeb37242fa0f30486195f45b9cf5361b78", | ||
| "contract": "0xb1e6f8820826491fcc5519f84ff4e2bdbb6e3cad" | ||
| "base_denom": "0xAb19BDAEb37242Fa0f30486195f45b9cF5361b78", |
There was a problem hiding this comment.
Error: Trace of carbon, cglp.1.19.1698d3 makes invalid reference to arbitrum, 0xAb19BDAEb37242Fa0f30486195f45b9cF5361b78.
It was probably correct before the letter casing was changed
There was a problem hiding this comment.
i amended the errors i have seen. Right now the validation is failing, i believe is because certain assets such as mantle and cmETH etc are not inside the non_cosmos asset list for mantle. What should i do about that ?
There was a problem hiding this comment.
For these assets whose reference is invalid, they need to be registered. So, .e.g., Mantle's assetlist.json must have MNT registered (currently not there). Same with cmETH which must be registered to the ethereum assetlist.
|
If no activity is seen on this soon it will be closed. |
No description provided.