Adding Bitrock EVM chain #6559
Adding Bitrock EVM chain #6559
Conversation
| "base_denom": "wei" | ||
| }, | ||
| "png": "https://raw.githubusercontent.com/cosmos/chain-registry/master/_non-cosmos/bitrock/images/wbrock.png", | ||
| "svg": "https://raw.githubusercontent.com/cosmos/chain-registry/master/_non-cosmos/bitrock/images/wbrock.svg" |
There was a problem hiding this comment.
Please remove the rock.svg and wbrock.svg uploads since they are somewhat unsightly conversions of PNG to SVG, and aren't really visually identical.
There was a problem hiding this comment.
I see rock.svg was replaced with a higher quality version, which is good. However the URL for wbrock.svg should now be removed since wbrock.svg was deleted
| "provider": "Bitrock Bridge" | ||
| } | ||
| ], | ||
| "coingecko_id": "bitrock", |
There was a problem hiding this comment.
Bridged assets cannot share the same coingecko_id as an original asset. If both the original asset and the bridge are from the same team and part of the same project, then the bridged version can be considered an "additional-mintage", instead of a "bridge" asset. Changing the trace "type" to "additional-mintage", and the "provider" to "Bitrock" should allow this to pass while allowing them to share the same coingecko ID
No description provided.