Skip to content

refactor(simulation): adjust unjail operation weight and clarify skip reason #25294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 12, 2025
Merged

refactor(simulation): adjust unjail operation weight and clarify skip reason #25294

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9fc08d7
Update operations.go
hawkadrian Aug 30, 2025
d5e05b2
Merge branch 'main' into hawkie
aljo242 Sep 2, 2025
72f801c
Merge branch 'main' into hawkie
aljo242 Sep 2, 2025
f29d341
Merge branch 'main' into hawkie
aljo242 Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions x/slashing/simulation/operations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import (
const (
OpWeightMsgUnjail = "op_weight_msg_unjail"

DefaultWeightMsgUnjail = 100
DefaultWeightMsgUnjail = 5 // Reduced from 100 since validators are rarely jailed in simulations
)

// WeightedOperations returns all the operations from the module with their respective weights
Expand Down Expand Up @@ -87,7 +87,8 @@ func SimulateMsgUnjail(
}

if !validator.IsJailed() {
// TODO: due to this condition this message is almost, if not always, skipped !
// This operation is often skipped because validators are rarely jailed in simulations.
// The weight has been reduced to 5 to reflect this reality.
return simtypes.NoOpMsg(types.ModuleName, msgType, "validator is not jailed"), nil, nil
}

Expand Down
Loading