Skip to content

Conversation

@yihuang
Copy link
Contributor

@yihuang yihuang commented Nov 24, 2025

Description

Co-authored-by: Marko [email protected]

  • stop minting if total supply already exceeds max supply
  • cleanup condition logic based on original PR.
  • need to update api dependency in another PR.

Co-authored-by: Marko <[email protected]>

remove cherry-pick commet errors

fix test

fix v3 migrate

simplify the condition

cleanup logic

Problem: minted coin could be negative

Solution:
- stop minting if total supply already exceeds max supply
@yihuang yihuang requested a review from aljo242 November 24, 2025 06:55
@aljo242
Copy link
Contributor

aljo242 commented Nov 25, 2025

@yihuang CI is broken

@yihuang
Copy link
Contributor Author

yihuang commented Nov 27, 2025

@yihuang CI is broken

I'm not sure how to handle the api package dependency, if we replace it to local directory, it'll complain x/group x/circuit not found, those removed apis are still referenced in many places.

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

❌ Patch coverage is 65.71429% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.33%. Comparing base (2a15457) to head (f234a35).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
x/mint/keeper/mint.go 55.55% 4 Missing ⚠️
x/mint/types/params.go 75.00% 3 Missing ⚠️
x/mint/keeper/migrator.go 0.00% 2 Missing ⚠️
x/mint/migrations/v3/migrate.go 75.00% 2 Missing ⚠️
x/mint/module.go 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #25599   +/-   ##
=======================================
  Coverage   70.33%   70.33%           
=======================================
  Files         821      822    +1     
  Lines       53771    53800   +29     
=======================================
+ Hits        37818    37840   +22     
- Misses      15953    15960    +7     
Files with missing lines Coverage Δ
x/mint/simulation/genesis.go 100.00% <100.00%> (ø)
x/mint/module.go 73.75% <66.66%> (-0.61%) ⬇️
x/mint/keeper/migrator.go 66.66% <0.00%> (-33.34%) ⬇️
x/mint/migrations/v3/migrate.go 75.00% <75.00%> (ø)
x/mint/types/params.go 92.22% <75.00%> (-2.72%) ⬇️
x/mint/keeper/mint.go 76.08% <55.55%> (-6.42%) ⬇️

... and 4 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aljo242
Copy link
Contributor

aljo242 commented Dec 1, 2025

#25613

is merged so the api diff should be fixed - needs a changelog

@yihuang
Copy link
Contributor Author

yihuang commented Dec 4, 2025

#25613

is merged so the api diff should be fixed - needs a changelog

I think we still need to merge the api changes first right? (#25612)

Otherwise if I replace api to relative directory:

replace cosmossdk.io/api => ../api

I'll get:

go: finding module for package cosmossdk.io/api/cosmos/group/v1
go: finding module for package cosmossdk.io/api/cosmos/circuit/module/v1
go: finding module for package cosmossdk.io/api/cosmos/nft/module/v1
cgo: github.com/cosmos/cosmos-sdk/tests/e2e/auth imports
	github.com/cosmos/cosmos-sdk/testutil/network imports
	github.com/cosmos/cosmos-sdk/testutil/configurator imports
	cosmossdk.io/api/cosmos/circuit/module/v1: module cosmossdk.io/api@latest found (v0.9.2, replaced by ../api), but does not contain package cosmossdk.io/api/cosmos/circuit/module/v1
go: github.com/cosmos/cosmos-sdk/tests/e2e/auth imports
	github.com/cosmos/cosmos-sdk/testutil/network imports
	github.com/cosmos/cosmos-sdk/testutil/configurator imports
	cosmossdk.io/api/cosmos/nft/module/v1: module cosmossdk.io/api@latest found (v0.9.2, replaced by ../api), but does not contain package cosmossdk.io/api/cosmos/nft/module/v1
go: github.com/cosmos/cosmos-sdk/tests/e2e/auth imports
	github.com/cosmos/cosmos-sdk/client imports
	cosmossdk.io/x/tx/signing tested by
	cosmossdk.io/x/tx/signing.test imports
	cosmossdk.io/api/cosmos/group/v1: module cosmossdk.io/api@latest found (v0.9.2, replaced by ../api), but does not contain package cosmossdk.io/api/cosmos/group/v1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants