feat: ERC20 precompile redesign #517
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
force-pushed
the
bank-precompile
branch
from
5c87197 to
73b20c7
Compare
yihuang
changed the title
yihuang
changed the title
Solution: - refactor the precompiles code with (hopefully) equivalent transformations. changelog cleanup handle balance handler error return cleanup avoid naked return fix lint fix werc20 fix staking precompile fix panic recovery return error fix staking test case NewPrecompile don't return error
yihuang
force-pushed
the
bank-precompile
branch
from
5c3043e to
205d009
Compare
|
We need some more time to review this. But my initial thoughts are that I like the |
those things are part of another PR: #577 this PR should only be merged after that one. |
Closes: cosmos#505 re-design bank precompile to support solidity erc20 contract. solc optimize fix readonly comment solc version add to app basic mock test framework test transfer test precompile through erc20 contract more failure test cases cleanup fix go lint use decimals from Display denom add to AvailableStaticPrecompiles add boilerplates use new precompile base fix executor fix test fix lint gas cost changed after register new precompile use cosmos-sdk gas config
yihuang
force-pushed
the
bank-precompile
branch
from
b67b1e0 to
07eaa87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #505
Re-design bank precompile to avoid dynamic precompiles.
e2e tests
Notes
go-ethereum/accounts/abilibrary.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranch