-
Notifications
You must be signed in to change notification settings - Fork 96
feat: prepare parallel tx execution with object stores #587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Revert "less" This reverts commit 21ef5c3.
for k, v := range keys { | ||
storeKeys[k] = v | ||
} |
Check warning
Code scanning / CodeQL
Iteration over map Warning
for k, v := range okeys { | ||
storeKeys[k] = v | ||
} |
Check warning
Code scanning / CodeQL
Iteration over map Warning
for _, key := range app.keys { | ||
keys = append(keys, key) | ||
} |
Check warning
Code scanning / CodeQL
Iteration over map Warning
for _, key := range app.tkeys { | ||
keys = append(keys, key) | ||
} |
Check warning
Code scanning / CodeQL
Iteration over map Warning
for _, key := range app.memKeys { | ||
keys = append(keys, key) | ||
} |
Check warning
Code scanning / CodeQL
Iteration over map Warning
for _, key := range app.okeys { | ||
keys = append(keys, key) | ||
} |
Check warning
Code scanning / CodeQL
Iteration over map Warning
cd x/precisebank/types && mockery --name BankKeeper --with-expecter --filename MockBankKeeper.go cd x/vm/types && mockery --name BankKeeper
Problem: native fee handler don't respect DefaultPriorityReduction
@@ -496,3 +496,36 @@ func (k Keeper) GetDenomMetaData(ctx context.Context, denom string) (banktypes.M | |||
func (k Keeper) SetDenomMetaData(ctx context.Context, denomMetaData banktypes.Metadata) { | |||
k.bk.SetDenomMetaData(ctx, denomMetaData) | |||
} | |||
|
|||
// SendCoinsFromAccountToModuleVirtual sends coins from account to a virtual module account. | |||
func (k Keeper) SendCoinsFromAccountToModuleVirtual( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Eric-Warehime just add fee related change for precise bank, WDYT?
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
main
branch