feat: Block STM #589
Draft
feat: Block STM #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 451e75a.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -6,6 +6,8 @@ | |||
| "fmt" | |||
| "io" | |||
| "os" | |||
| goruntime "runtime" | |||
| "sort" | |||
Check notice
Code scanning / CodeQL
Sensitive package import Note
Comment on lines
+297
to
+300
| allKeys = append(allKeys, k) | ||
| nonTransientKeys = append(nonTransientKeys, k) | ||
| } | ||
| for _, k := range tkeys { |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Comment on lines
+301
to
+303
| allKeys = append(allKeys, k) | ||
| } | ||
| for _, k := range okeys { |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Comment on lines
+304
to
+307
| allKeys = append(allKeys, k) | ||
| nonTransientKeys = append(nonTransientKeys, k) | ||
| } | ||
| sort.SliceStable(allKeys, func(i, j int) bool { return allKeys[i].Name() < allKeys[j].Name() }) |
Check warning
Code scanning / CodeQL
Iteration over map Warning
mmsqe
reviewed
Sep 10, 2025
|
|
||
| // Stack of cached store | ||
| cacheStores []storetypes.CacheKVStore | ||
| cacheStores []storetypes.CacheWrap |
There was a problem hiding this comment.
actually I felt a bit hacky like 04f5ae2 when doing cast for snapshotKVStore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Draft for integrating block stm.
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranch