-
Notifications
You must be signed in to change notification settings - Fork 2
refactor: pre-generate data and rewrite benchmarks #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aaronc
wants to merge
67
commits into
main
Choose a base branch
from
aaronc/updates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A complete reworking of the existing benchmarking code that uses the same data generation algorithm.
To generate data run
cmd/gen_changesets
frombench/
. For example to generate 100 versions of data in thetestdata/
dir (using the default "small" profile):The test changeset data for each version will be in an individual protobuf file in the
testdata/
directory which can be streamed incrementally into the test runner. Given the size of data we are trying to generate (40M initial entries with the "osmosis" profile), it was necessary to both generate and apply the data using streaming.Benchmark runners for
iavl-v1
,iavl-v2
andmemiavl
have been updated to use a unified benchmark runner so that the benchmarks and results are as similar as possible for each tree. (iavl-v0 and store-v2 code has not been updated).To run benchmarks for a tree, cd into that directory and run: