CBL-6606 : LogSinks C++ Wrapper API #588
Merged
+217
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented LogSinks C++ Wrapper API and add sanity API tests.
|
Code Coverage Results:
|
|
I don't quite understand the purpose of this thing. Is it, perhaps, just about visibility? |
bmeike
approved these changes
Jan 10, 2025
velicuvlad
approved these changes
Jan 13, 2025
|
It looks like the Android validation won't run. GHA runners seems to be deprecated macos 12 a while back, but they just moved it to unsupported now at the start of Jan. And the Android validation is set to run only on 12. |
Yes, just make it visible via the C++ API (not C API). |
|
I have tried to update the use the new macOS but I couldn't get the android SDK and tools to install due to some mismatched Java version. Will try later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented LogSinks C++ Wrapper API and add sanity API tests.