Fix pinnedServerCertificate not getting retained

CBLReplicatorConfiguration.pinnedServerCertificate is Core Foundation type so explicitly retaining and releasing are required.
couchbase · Oct 20, 2018 · 0e4aaf2 · 0e4aaf2
1 parent 7285693
commit 0e4aaf2
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/Objective-C/CBLReplicatorConfiguration.m b/Objective-C/CBLReplicatorConfiguration.m
@@ -86,7 +86,11 @@ - (void) setAuthenticator: (CBLAuthenticator *)authenticator {
 
 - (void) setPinnedServerCertificate: (SecCertificateRef)pinnedServerCertificate {
     [self checkReadonly];
-    _pinnedServerCertificate = pinnedServerCertificate;
+    if (_pinnedServerCertificate != pinnedServerCertificate) {
+        cfrelease(_pinnedServerCertificate);
+        _pinnedServerCertificate = pinnedServerCertificate;
+        cfretain(_pinnedServerCertificate);
+    }
 }
 
 
@@ -187,4 +191,9 @@ - (NSDictionary*) effectiveOptions {
 }
 
 
+- (void) dealloc {
+    cfrelease(_pinnedServerCertificate);
+}
+
+
 @end