Skip to content

updated intro page for SGW #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: release/3.2
Choose a base branch
from

Conversation

iamfortune
Copy link
Contributor

@iamfortune iamfortune commented Jul 1, 2025

Docs Issue: DOC-13353

Docs Preview: URL

You will need the Docs Team credentials on Confluence.

@iamfortune iamfortune requested review from bbrks, idulo and simon-dew July 1, 2025 15:05
iamfortune and others added 5 commits July 3, 2025 11:01
This requires ui prod-213, and an asciidoc hack with empty section to close
out the previous flex basis :sadpanda:
Copy link
Contributor

@torcolvin torcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks technically correct to me from a developer perspective.

There are a few things I would rather not highlight on the starting page, such as Indexing vs Views. Is the intention to have a full TOC on the starting page, or just show common and useful information?

If the intention is to show useful information, I will have more comments. If the intention is to be a TOC of all the stuff in the sidebar, then some sections are missing. e.g. Deploy in the sidebar has more items than in the main page.


You can read more about the Data Synchronization process in {sync-with-couchbase-server--xref}.
Some of its most central, and commonly used features, are those used to ensure secure **Access Control**.
* Role-Based Access Control.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be up to the PM and docs team, but it is weird to me that RBAC and RESTful API are in both sections Why Use Sync Gateway? and Key Capabilities

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is to show common and useful information

Comment on lines +92 to +94
* xref:rest-api-access.adoc[]
* xref:rest-api-admin.adoc[]
* xref:rest-api-metrics.adoc[]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ultimately a question for docs team but since we switched from swagger to redocly, some of these pages are really just pass through to openapi and have actually no content

https://preview.docs-test.couchbase.com/docs-sync-gateway-DOC-13353-update-SGW-intro-page/sync-gateway/current/rest-api.html

https://preview.docs-test.couchbase.com/docs-sync-gateway-DOC-13353-update-SGW-intro-page/sync-gateway/current/rest_api_public.html

This definitely could be outside the scope of this review, I was just testing the links here.

If there's extra information on any of these pages. I find it annoying as a consumer of the docs to be sent to https://preview.docs-test.couchbase.com/docs-sync-gateway-DOC-13353-update-SGW-intro-page/sync-gateway/current/rest-api.html only to have to click through to https://preview.docs-test.couchbase.com/docs-sync-gateway-DOC-13353-update-SGW-intro-page/sync-gateway/current/rest_api_public.html

The same is true for admin and metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants