Fix: python3 + migrate PyCrypto to PyCryptodome + parsing splitted strings in TXT records #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yann 'Ze' Richard <[email protected]>
PyCrypto 2.x is unmaintained, obsolete, and contains security vulnerabilities. Python package : pycryptodomex Debian package : python3-pycryptodome Signed-off-by: Yann 'Ze' Richard <[email protected]>
Because of RFC 1035 section 2.3.4 TXT records are limited to 255 characters. However RFC 4408 allow to split string into portions of 255 characters : - Size Limits: https://www.rfc-editor.org/rfc/rfc1035.html#section-2.3.4 - TXT RDATA format : https://www.rfc-editor.org/rfc/rfc1035.html#section-3.3.14 - Multiple Strings in a Single DNS record : https://www.rfc-editor.org/rfc/rfc4408#section-3.1.3 From : countsudoku@3863dd8 Author : https://github.com/countsudoku
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1