Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced deprecated $.browser.msie with method that doesnt resort to ... #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JimWolff
Copy link

@JimWolff JimWolff commented Sep 2, 2013

@konsumer
Copy link

konsumer commented Sep 3, 2013

I think #30 is a better solution.

@JimWolff
Copy link
Author

JimWolff commented Sep 3, 2013

Definatly a cleaner solution, i just red the other solution was more reliable.
After a bit more reading on the subject i found out the snippit was originally taken from a this gist
I however also found that conditional comments are not supported in IE 10.

@zzgab
Copy link

zzgab commented Feb 25, 2015

So, guys, what is the proper pull request in the end, if I want to use a fork that solves this $.browser issue in the best way to your knowledge?

@konsumer
Copy link

#34 or #36
#36 is basically the same solution, but first check for IE is slightly faster for non-IE in #36. Both solve it well.

@zzgab
Copy link

zzgab commented Feb 26, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants