Updates wallet connection and chain switch flows to support wagmi #6899
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| import { useCallback } from 'react' | ||
|
|
||
| import { Command } from '@cowprotocol/types' | ||
|
|
||
| import { useDisconnect } from 'wagmi' | ||
|
|
||
| export function useDisconnectWallet(onDisconnect?: Command): () => Promise<void> { | ||
| const { mutateAsync: disconnect } = useDisconnect() | ||
|
|
||
| return useCallback(async () => { | ||
| await disconnect() | ||
|
|
||
| onDisconnect?.() | ||
| }, [disconnect, onDisconnect]) | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: cowprotocol/cowswap
Length of output: 257
🏁 Script executed:
Repository: cowprotocol/cowswap
Length of output: 268
🏁 Script executed:
Repository: cowprotocol/cowswap
Length of output: 5412
🌐 Web query:
@reown/appkit/react v1.8.17 useAppKit hook open() method behavior toggle or open only💡 Result:
In
@reown/appkit/reactv1.8.17,useAppKit().open()is open-only (idempotent), not a toggle—you close the modal withuseAppKit().close(). The modal’s current visibility is exposed viauseAppKitState()(open: boolean). [1] [2]If you want toggle behavior, implement it yourself:
Sources: [useAppKit / open+close] [1], [useAppKitState / open boolean] [2].
[1] (docs.reown.com)
[2] (docs.reown.com)
Citations:
🏁 Script executed:
Repository: cowprotocol/cowswap
Length of output: 1143
🏁 Script executed:
Repository: cowprotocol/cowswap
Length of output: 1630
Fix toggle semantics and stabilize the callback.
When the flag is on, the hook returns a new inline function that only calls
open(). Since@reown/appkit/react@1.8.17treatsopen()as open-only (not a toggle), callers expecting close-on-second-click lose that behavior. Additionally, creating a new function each render creates referential instability for memoized children.Use
useAppKitState()andclose()to properly implement toggle semantics, wrapped inuseCallbackfor stability:♻️ Suggested refactor
export function useToggleWalletModal(): Command { - const { open } = useAppKit() + const { open, close } = useAppKit() + const { open: isOpen } = useAppKitState() const toggleModal = useToggleModal(ApplicationModal.WALLET) - if (LAUNCH_DARKLY_VIEM_MIGRATION) { - return () => open() - } - - return toggleModal + return useCallback(() => { + if (LAUNCH_DARKLY_VIEM_MIGRATION) { + isOpen ? close() : open() + return + } + toggleModal() + }, [open, close, isOpen, toggleModal]) }🤖 Prompt for AI Agents