[feat][evaluation] add failed evaluator record creation and handling - #563
Merged
Merged
Conversation
1. add CreateEvaluatorRunFailRecord method to generate failure records before normal run persists 2. update sync/async evaluator calls to create failure records when run fails 3. add validation for missing evaluator results and update turn run status 4. add corresponding mocks and test cases
…reation Rewrite the error handling logic for CreateEvaluatorRunFailRecord to: 1. Use proper errorx status error parsing consistently 2. Correct the conditional check for custom RPC error skip logic 3. Add comprehensive unit test cases covering multiple error scenarios 4. Standardize error message stripping and code extraction
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #563 +/- ##
=======================================
Coverage 77.82% 77.83%
=======================================
Files 670 670
Lines 76151 76234 +83
=======================================
+ Hits 59268 59338 +70
- Misses 13421 13428 +7
- Partials 3462 3468 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
lsy357
previously approved these changes
Jun 25, 2026
lsy357
approved these changes
Jun 25, 2026
tpfz
approved these changes
Jun 25, 2026
Colin4k1024
pushed a commit
to Colin4k1024/coze-loop
that referenced
this pull request
Aug 28, 2026
…oze-dev#563) * feat(evaluation): add failed evaluator record creation and handling 1. add CreateEvaluatorRunFailRecord method to generate failure records before normal run persists 2. update sync/async evaluator calls to create failure records when run fails 3. add validation for missing evaluator results and update turn run status 4. add corresponding mocks and test cases * refactor(evaluator): simplify and fix error handling in fail record creation Rewrite the error handling logic for CreateEvaluatorRunFailRecord to: 1. Use proper errorx status error parsing consistently 2. Correct the conditional check for custom RPC error skip logic 3. Add comprehensive unit test cases covering multiple error scenarios 4. Standardize error message stripping and code extraction * Add error path coverage for evaluator failure records * Refactor evaluator error assertions in turn impl test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Check the PR title
(Optional) Translate the PR title into Chinese
(Optional) More detailed description for this PR(en: English/zh: Chinese)
en:
zh(optional):
(Optional) Which issue(s) this PR fixes