[fix][evaluation] clean up runs rejected before dispatch - #677
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #677 +/- ##
==========================================
+ Coverage 78.84% 78.86% +0.02%
==========================================
Files 707 707
Lines 87896 87928 +32
==========================================
+ Hits 69298 69346 +48
+ Misses 14607 14599 -8
+ Partials 3991 3983 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
bitholic
force-pushed
the
fix/retry-quota-lock-cleanup
branch
from
September 28, 2026 07:58
a67c0c5 to
f53cb19
Compare
bitholic
force-pushed
the
fix/retry-quota-lock-cleanup
branch
from
September 28, 2026 08:27
f53cb19 to
2d05005
Compare
xueyizheng
approved these changes
Sep 28, 2026
Celoria
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When run admission fails after creating a run and acquiring its mutex, the pending run and lock were left behind. This change shares pre-dispatch checks across Run and RetryItems, marks rejected runs failed before releasing the lock, and preserves the original error. Ambiguous MQ publication failures keep the lock.
Validation: eight regression scenarios, full evaluation service/application tests, go vet, and commercial integration build passed.