Skip to content

[fix][evaluation] clean up runs rejected before dispatch - #677

Merged
bitholic merged 1 commit into
mainfrom
fix/retry-quota-lock-cleanup
Sep 28, 2026
Merged

bitholic merged 1 commit into
mainfrom
fix/retry-quota-lock-cleanup

Conversation

@bitholic

Copy link
Copy Markdown
Collaborator

When run admission fails after creating a run and acquiring its mutex, the pending run and lock were left behind. This change shares pre-dispatch checks across Run and RetryItems, marks rejected runs failed before releasing the lock, and preserves the original error. Ambiguous MQ publication failures keep the lock.

Validation: eight regression scenarios, full evaluation service/application tests, go vet, and commercial integration build passed.

@codecov

codecov Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #677      +/-   ##
==========================================
+ Coverage   78.84%   78.86%   +0.02%     
==========================================
  Files         707      707              
  Lines       87896    87928      +32     
==========================================
+ Hits        69298    69346      +48     
+ Misses      14607    14599       -8     
+ Partials     3991     3983       -8     
Flag Coverage Δ
unittests 78.86% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ation/domain/service/expt_manage_execution_impl.go 84.05% <100.00%> (+1.49%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71c4cb4...2d05005. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bitholic
bitholic force-pushed the fix/retry-quota-lock-cleanup branch from a67c0c5 to f53cb19 Compare September 28, 2026 07:58
@bitholic
bitholic force-pushed the fix/retry-quota-lock-cleanup branch from f53cb19 to 2d05005 Compare September 28, 2026 08:27
@bitholic
bitholic merged commit 3a6a2bf into main Sep 28, 2026
16 checks passed
@bitholic
bitholic deleted the fix/retry-quota-lock-cleanup branch September 28, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants