implement duration type #5
Conversation
Signed-off-by: Andrei Kvapil <[email protected]>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @kvaps, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new duration type to the system, which is crucial for defining and validating time-based fields in generated API schemas or configurations. By implementing duration as a string with a robust regular expression pattern, the change enhances data validation and ensures consistency for temporal data within the system.
Highlights
- New
durationtype: Introduced a newdurationtype, implemented as astringwith akubebuilder:validation:Patternannotation. This pattern enforces a specific time duration format (e.g.,1h30m,5s,100ms,1ns) for validation purposes. - Type System Integration: Integrated the new
durationtype into the core type resolution logic. It is now recognized as a primitive type and is resolved to astringfor code generation and schema interpretation, similar to howquantitytypes are handled. - Default Value Handling: Updated the default value formatting logic to correctly handle
durationtypes. Default values fordurationwill now be enclosed in quotes, consistent with howstringandquantitytypes are formatted.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a new duration type, similar to the existing quantity type, for use in value definitions. The implementation is mostly correct, adding duration to primitive type checks and handling it for default value formatting. However, the validation regex for the new duration type allows invalid duration strings, which has been corrected in the code suggestion.
| // +kubebuilder:validation:Pattern=` + "`" + `^-?(\d+h(\d+m)?(\d+s)?(\d+ms)?(\d+us)?(\d+µs)?(\d+ns)?|\d+m(\d+s)?(\d+ms)?(\d+us)?(\d+µs)?(\d+ns)?|\d+s(\d+ms)?(\d+us)?(\d+µs)?(\d+ns)?|\d+ms(\d+us)?(\d+µs)?(\d+ns)?|\d+us(\d+µs)?(\d+ns)?|\d+µs(\d+ns)?|\d+ns)$` + "`" + ` | ||
| type duration string |
There was a problem hiding this comment.
The regular expression for duration validation is incorrect as it allows both us and µs to be present in the same duration string (e.g., 1us1µs). This is invalid for Go's time.ParseDuration since us and µs are aliases for microseconds and cannot be used together.
| // +kubebuilder:validation:Pattern=` + "`" + `^-?(\d+h(\d+m)?(\d+s)?(\d+ms)?(\d+us)?(\d+µs)?(\d+ns)?|\d+m(\d+s)?(\d+ms)?(\d+us)?(\d+µs)?(\d+ns)?|\d+s(\d+ms)?(\d+us)?(\d+µs)?(\d+ns)?|\d+ms(\d+us)?(\d+µs)?(\d+ns)?|\d+us(\d+µs)?(\d+ns)?|\d+µs(\d+ns)?|\d+ns)$` + "`" + ` | |
| type duration string | |
| // +kubebuilder:validation:Pattern=` + "`" + `^-?(\d+h(\d+m)?(\d+s)?(\d+ms)?(\d+(?:us|µs))?(\d+ns)?|\d+m(\d+s)?(\d+ms)?(\d+(?:us|µs))?(\d+ns)?|\d+s(\d+ms)?(\d+(?:us|µs))?(\d+ns)?|\d+ms(\d+(?:us|µs))?(\d+ns)?|\d+(?:us|µs)(\d+ns)?|\d+ns)$` + "`" + ` | |
| type duration string |
Signed-off-by: Andrei Kvapil [email protected]