test: add coverage for AccessorBase and LetsEncrypt#81
Draft
toddr-bot wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add dedicated test files for two untested user-facing modules, and regenerate README.md.
Why
After merging 49 PRs,
AccessorBase.pm(the AUTOLOAD-based accessor engine used by Order, Authorization, and Challenge) andLetsEncrypt.pm(the concrete subclass users instantiate) had zero direct test coverage. Both are on the critical path for users.How
t/Net-ACME2-AccessorBase.t(12 tests): constructor key prefixing, AUTOLOAD dispatch for valid accessors, undef handling, unknown method error, DESTROY silence.t/Net-ACME2-LetsEncrypt.t(6 tests): HOST() routing for production/staging/invalid, DIRECTORY_PATH constant, subclass relationship.Testing
Full suite: 397 tests across 25 files, all pass.
Quality Report
Changes: 4 files changed, 138 insertions(+)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan