doc: fix list.import standalone example to use CALL directive#440
Merged
Conversation
list.import() returns the list reference to support chaining (.import().join()), but when used standalone this leaks ARRAY(0x...) into template output. Update VMethods.pod to use the CALL directive in the standalone example and document why. Add tests for standalone CALL usage patterns. Closes #134 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
list.import()vmethod returns the list reference to support chaining (.import().join()), but when used standalone this leaksARRAY(0x...)into template output. The VMethods.pod documentation showed standalone usage without theCALLdirective, which produced the reported bug output.Updated the standalone example to use
CALL one.import(two, three)and added explanatory text about whyCALLis needed when not chaining. Added tests for standalone CALL usage patterns.Closes #134
Changes
lib/Template/Manual/VMethods.podstandalone import example to useCALLdirectiveimportreturns the list reference for chainingCALLimport usage int/vmethods/list.tTest plan
CALL one.import(two)andCALL one.import(two, three)produce clean outputGenerated by Kōan
Quality Report
Changes: 2 files changed, 25 insertions(+), 3 deletions(-)
Code scan: clean
Tests: failed (1 Failed, 15 tests)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline