Skip to content

fix: prefer suffixed locales to avoid Perl 5.42.0 panic (GH #448) #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
toddr-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: prefer suffixed locales to avoid Perl 5.42.0 panic (GH #448) #450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/Template/Plugin/Date.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ use constant HAS_SETLOCALE => $Config::Config{d_setlocale};

our $VERSION = '3.106';
our $FORMAT = '%H:%M:%S %d-%b-%Y'; # default strftime() format
our @LOCALE_SUFFIX = qw( .ISO8859-1 .ISO_8859-15 .US-ASCII .UTF-8 );
our @LOCALE_SUFFIX = qw( .UTF-8 .ISO8859-1 .ISO_8859-15 .US-ASCII );


#------------------------------------------------------------------------
Expand Down Expand Up @@ -164,7 +164,7 @@ sub format {
: undef;

# some systems expect locales to have a particular suffix
for my $suffix ('', @LOCALE_SUFFIX) {
for my $suffix (@LOCALE_SUFFIX, '') {
my $try_locale = $locale.$suffix;
my $setlocale = HAS_SETLOCALE
? &POSIX::setlocale(&POSIX::LC_ALL, $try_locale)
Expand Down
2 changes: 1 addition & 1 deletion t/date.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ sub time_locale {
: undef;

# some systems expect locales to have a particular suffix
for my $suffix ('', @Template::Plugin::Date::LOCALE_SUFFIX) {
for my $suffix (@Template::Plugin::Date::LOCALE_SUFFIX, '') {
my $try_locale = $locale.$suffix;
my $setlocale = $Config{d_setlocale}
? &POSIX::setlocale(&POSIX::LC_ALL, $try_locale)
Expand Down