Skip to content

Fix typo and remove redundant blank space #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 9, 2025
Merged

Fix typo and remove redundant blank space #29

merged 2 commits into from
Aug 9, 2025

Conversation

Mes0903
Copy link
Member

@Mes0903 Mes0903 commented Aug 9, 2025

  • Correct vk::QueueCreateInfo to vk::DeviceQueueCreateInfo in the guide
  • Remove redundant blank space

@Mes0903 Mes0903 requested a review from karnkaul August 9, 2025 06:26
karnkaul
karnkaul approved these changes Aug 9, 2025
View reviewed changes
Copy link
Member

@karnkaul karnkaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@karnkaul karnkaul merged commit 7c0f122 into cpp-gamedev:main Aug 9, 2025
8 checks passed
karnkaul added a commit that referenced this pull request Aug 10, 2025
@Mes0903 @karnkaul @CDDing
Translate chapter 2 into Traditional Chinese (zh-TW) (#30)
aec3b4c 
* CI: add `workflow_dispatch`

* Port present semaphore sync fix to main (#26)

* 🐛 Fix present semaphore sync  (#25)

* Refactor build scripts and presets (#24)

- Move compile flags to presets
- Update CI script

* 🐛 Fix present semaphore sync

Discovered on SDK 1.4.313

* Fixup guide

* Fixup guide

* ko-translation revised (#27)

* Fix typo and remove redundant blank space (#29)

* Fix typo and remove redundant blank space

* Fix typo

* Translate chapter 2 into Traditional Chinese

---------

Co-authored-by: Karn Kaul <[email protected]>
Co-authored-by: MyungKun Chang <[email protected]>
@Mes0903 Mes0903 deleted the fix/typo branch August 10, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karnkaul karnkaul karnkaul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mes0903 @karnkaul