ci: test MSVC 14.44 and 14.51 on x64 and ARM64 - #375
Merged
Merged
Conversation
This change replaces the MSVC jobs with these jobs: - 14.44 on x64, on the windows-2022 runner (is_earliest). CMake uses the Visual Studio 17 2022 generator. - 14.51 on x64, on the windows-2025-vs2026 runner (is_latest). CMake uses the Ninja generator. The ASan variant moves with is_latest. - 14.44 on ARM64, on the windows-11-vs2026-arm runner. This job uses the side-by-side toolset of the image. - 14.51 on ARM64, on the windows-11-vs2026-arm runner. This change removes the 14.34 jobs. No hosted runner has 14.34, and those jobs compiled with the default toolset of the image. The new msvc_toolset field in compilers.json selects a side-by-side toolset. For this field, the Configure MSVC step writes a B2 user-config. The user-config sets a setup script that gives -vcvars_ver to vcvarsall. B2 runs this script before it builds. The Configure MSVC step also compares the cl banner with the matrix. The step gets the target architecture from RUNNER_ARCH. If the version or the target architecture is different, the step stops with an error. In cancel_close_stress_test, a separate coroutine lambda now runs each iteration of the worker. This change prevents an internal compiler error (C1001) in MSVC 19.51.36257 for x64 at /O2. The compiler fails when a co_await is in a counted loop in the try block of a coroutine. The iterations, counters, cancellation mix and assertions do not change.
|
GCOVR code coverage report https://375.corosio.prtest3.cppalliance.org/gcovr/index.html Build time: 2026-09-30 19:33:49 UTC |
sgerbino
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change replaces the MSVC jobs with these jobs:
This change removes the 14.34 jobs. No hosted runner has 14.34, and those jobs compiled with the default toolset of the image.
The new msvc_toolset field in compilers.json selects a side-by-side toolset. For this field, the Configure MSVC step writes a B2 user-config. The user-config sets a setup script that gives -vcvars_ver to vcvarsall. B2 runs this script before it builds.
The Configure MSVC step also compares the cl banner with the matrix. The step gets the target architecture from RUNNER_ARCH. If the version or the target architecture is different, the step stops with an error.
In cancel_close_stress_test, a separate coroutine lambda now runs each iteration of the worker. This change prevents an internal compiler error (C1001) in MSVC 19.51.36257 for x64 at /O2. The compiler fails when a co_await is in a counted loop in the try block of a coroutine. The iterations, counters, cancellation mix and assertions do not change.