-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New mapper (MOS-1827) #32
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cool Story:
The differential tree isn't being constructed optimally when there are many changes, especially in cases where multiple methods are added or removed from a class (all changes occur within a single node representing the class body), or when multiple lines are added, modified, or removed within a method (changes are contained within a single node representing the method body). The greedy algorithm used in this scenario attempts to match the first child nodes, but this is not the most efficient approach. As a result, the differential tree ends up being "crooked," which leads to similarly flawed patterns being generated.
Task:
Refactor the differential tree construction algorithm to handle complex changes more efficiently, particularly when multiple modifications occur within a single node (such as class bodies or method bodies). Improve the tree-building logic so that it avoids suboptimal matches and ensures that the resulting patterns are accurate.