ZoneOffset.of("Z") must return UTC #520
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #518
It seems that this used to work, but relied on the fact that
ZoneOffset.UTC
will put "Z" inID_CACHE when object is initialised.
This no longer works because ZoneOffset.UTC was made into a lazy val, so invoking
ZoneOffset.of("Z")
will not trigger theZoneOffset.UTC
calculation.To confirm, just touching ZoneOffset.UTC is enough to make repro work:
I feel like relying on this cache behaviour is too brittle, so I decided to explictly special-case "Z" as it's a special case in java docs as well.
Note that this case is already tested, but one of the previous tests refers to ZoneOffset.UTC, triggering the cache update.