Skip to content

Bug #354: Changed logic in print.js/loadIframeImage to prevent an infinite loop when an image is broken #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bug #354: Changed logic in print.js/loadIframeImage to prevent an infinite loop when an image is broken #357

wants to merge 1 commit into from

Conversation

desrochers
Copy link

No description provided.

Update print.js
3642bc5 
Bug crabbly#354: Changed logic in print.js/loadIframeImage to prevent an infinite loop when an image is broken
@coveralls
Copy link

Pull Request Test Coverage Report for Build 277

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 46.309%
Totals Coverage Status
Change from base Build 276: 0.0%
Covered Lines: 232
Relevant Lines: 362
💛 - Coveralls

@papscript
Copy link

papscript commented Apr 30, 2021 •
edited
Loading

@crabbly Is there a chance we're going to have this one merged soon?

How about this week? :)

@papscript papscript mentioned this pull request Apr 30, 2021
Open
@neilguangzhou
Copy link

I have this problem too. Hope We can get the merged code as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@desrochers @coveralls @papscript @neilguangzhou