Open
Conversation
Contributor
Author
|
Opened the pr again for review (excluding CI for now) |
…ger calls. This replaces every world.robot call with RobotManager.get_active_robot() and every RobotDescription.current_robot_description with RobotManager.geet_robot_description()
…robot for ros_utils
This change was made, as multiple robots are added into the world structure for MultiRobotTests and would otherwise break other tests
This uses justin as secondary robot instead of tiago, as justin is ros2 compatible and resources are available in iai_robot
LucaKro
requested changes
Aug 14, 2025
Collaborator
LucaKro
left a comment
LucaKro
left a comment
There was a problem hiding this comment.
some small clarifications and method signature typing, but otherwise good work
LucaKro
requested changes
Aug 22, 2025
LucaKro
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the
RobotManagerclass, which enables managing and controlling multiple robots within a world environment.Changes
World.robotandRobotDescription.current_robot_descriptionwith:RobotManager.get_active_robot()RobotManager.get_robot_description()with_robotstatement by passing the respective robot object.Example:
with_real_robot(pr2_robot)