Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) add v to default version tag #127

Merged
merged 1 commit into from
Jul 16, 2019
Merged

(feat) add v to default version tag #127

merged 1 commit into from
Jul 16, 2019

Conversation

sunng87
Copy link
Collaborator

@sunng87 sunng87 commented Jun 16, 2019

Fixes #124

@sunng87 sunng87 requested a review from epage June 16, 2019 15:08
@epage
Copy link
Collaborator

epage commented Jun 17, 2019

We should remember to note in a changelog that we've broken compatibility but that people can revert to the old behavior be setting the tag-name.

@sunng87 sunng87 merged commit 120ea20 into master Jul 16, 2019
@sunng87 sunng87 deleted the feature/default-tag-prefix branch July 21, 2019 07:21
@sunng87
Copy link
Collaborator Author

sunng87 commented Jul 21, 2019

hi @epage I just invited you as owner of cargo-release on crate.io, did you receive the invitation?

It seems with two owners on a crate, we can move forward on scenario described in #119

@epage
Copy link
Collaborator

epage commented Jul 22, 2019

Accepted. Didn't get a notification but did see it when I knew to look for it.

dustymabe added a commit to dustymabe/coreos-installer that referenced this pull request Jan 8, 2020
@dustymabe
Cargo.toml: use default tag prefix
42acdb3 
The default changed to just be "v" upstream [1] so leaving this in
the way we had it meant we got "vv0.1.2", which is not what we want.

[1] crate-ci/cargo-release#127
[2] crate-ci/cargo-release@120ea20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epage epage epage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add v into the default tag format?
2 participants
@sunng87 @epage