Theme: Update to crate-docs-theme==0.34.0.dev6 #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
It certainly makes a difference, for example here. We will have to decide if we want it or not.
Before/AfterA picture says...
/cc @msbt, @matkuliak, @simonprickett, @karynzv, @hammerhead, @hlcianfagna, @surister, @proddata |
- Uses beta version of next generation theme. - Increases toctree maxdepth to 4.
amotl
force-pushed
the
amo/more-new-theme
branch
from
ebd1dfa to
253d19e
Compare
amotl
changed the title
Member
Author
|
When there are no strong objections against it, I will be merging this update patch. The CrateDB Guide has been used as a canary to run the modernized documentation theme on production for evaluation purposes, already before. This just brings it to the most recent beta release, resolving a few hiccups, fixed by @msbt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Note
Increases toctree maxdepth to 4. That may be good, or not, or it doesn't matter at all. Before, it was 3. See crate/crate-docs-theme#515.
Preview
https://cratedb-guide--112.org.readthedocs.build/