-
Notifications
You must be signed in to change notification settings - Fork 0
Remove workaround for _-prefixed column names
#30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| ## Unreleased | ||
| - Removed `SystemColumnWorkaround` for `_`-prefixed column names. | ||
| The package now requires CrateDB 6.2 or higher. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I see on the release notes the CrateDB 6.2 release might be far away (expecting 6.1 first?), this patch is probably not ready for releasing, and should be made a draft again for the time being?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6.1 will be released soon, 6.2 jan/feb 2026 though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Because this package has 4k downloads/month already, we will probably hold this update back until CrateDB 6.2 has been released. In this spirit, I am toggling it into draft mode again.
matriv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, but Let's pause it. This will work for long time only with nightly builds, until 6.2 is out beginning of 2026.
About
With CrateDB 6.2, the workaround against
_-prefixed column names is no longer needed. Thanks! 🌻References
InvalidColumnNameException["_foo" conflicts with system column pattern]crate#15161_-prefixed column names cratedb-fivetran-destination#83_-prefixed column names crate-workbench/meltano-target-cratedb#57/cc @hammerhead, @surister, @kneth