Remove redundant q.reset() calls and unused import#24
Open
hristog wants to merge 1 commit intocrazy4pi314:mainfrom
Open
Remove redundant q.reset() calls and unused import#24hristog wants to merge 1 commit intocrazy4pi314:mainfrom
hristog wants to merge 1 commit intocrazy4pi314:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the
QuantumDeviceinterface, the qubitreset()operation already takes place upon exiting from theusing_devicecontext manager, and this PR proposes removal of a couple of places where an explicitq.reset()is called immediately prior to exiting from theusing_devicecontext manager.This PR supposes that the proposed-for-removal
q.reset()lines weren't introduced explicitly with the intention of emphasizing that the operation would take place in a non-simulated context (as I suspect the case might have been here; if not - I would be happy to update this PR and remove that explicitq.reset()as well).Thanks for reviewing this PR!