Skip to content

Conversation

henderkes
Copy link
Collaborator

What does this PR do?

WIP

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If you modified *.php or *.json, run them locally to ensure your changes are valid:
    • composer cs-fix
    • composer analyse
    • composer test
    • bin/spc dev:sort-config
  • If it's an extension or dependency update, please ensure the following:
    • Add your test combination to src/globals/test-extensions.php.
    • If adding new or fixing bugs, add commit message containing extension test or test extensions to trigger full test suite.

@henderkes henderkes requested a review from crazywhalecc October 2, 2025 14:20
@henderkes
Copy link
Collaborator Author

see #911

@henderkes
Copy link
Collaborator Author

Maybe simpler idea: extract to php-src/zip/spc-shared and if the directory exists, build from there in Extension.php. Not sure if this would also override $this->source_dir, though.

@henderkes
Copy link
Collaborator Author

The only frequently changing version of these is zip. Maybe instead of doing something special here, we can just override the buildshared method of zip.php.

@henderkes henderkes closed this Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant