Skip to content

Update publish to use new container #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

Update publish to use new container #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/gh-pages.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
name: Build and publish docs

on:
push:
branches:
- "main"
pull_request: {}
workflow_dispatch:

jobs:
build:
runs-on: ${{ matrix.os }}
Expand All @@ -15,8 +18,10 @@ jobs:
steps:
- name: Check out repository code
uses: actions/checkout@v4

- name: Build docs
run: podman run --rm -v $PWD:/workspace quay.io/crc-org/mdbook:0.4.43 build
run: podman run --rm -v $PWD:/workspace ghcr.io/crc-org/mdbook:latest build
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Pinned version recommendation for mdbook image instead of using 'latest'.

Specifying an exact mdbook version prevents unexpected build changes when the image updates and ensures reproducible builds.

Suggested change
run: podman run --rm -v $PWD:/workspace ghcr.io/crc-org/mdbook:latest build
run: podman run --rm -v $PWD:/workspace ghcr.io/crc-org/mdbook:0.4.43 build


- name: Deploy
uses: peaceiris/actions-gh-pages@v4
if: github.ref == 'refs/heads/main'
Expand Down