Skip to content

{WIP] disable nodeip-configuration service #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release-4.18
Choose a base branch
from
Open

{WIP] disable nodeip-configuration service #1059

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions createdisk.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ wait_for_ssh ${VM_NAME} ${VM_IP}

if [ ${BUNDLE_TYPE} != "microshift" ]; then
# Disable kubelet service
${SSH} core@${VM_IP} -- sudo systemctl disable kubelet
${SSH} core@${VM_IP} -- sudo systemctl disable kubelet nodeip-configuration
Comment on lines 52 to +53
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (bug_risk): Disabled nodeip-configuration but not stopped it

Run systemctl stop nodeip-configuration or use --now to disable and stop it.

Suggested change
# Disable kubelet service
${SSH} core@${VM_IP} -- sudo systemctl disable kubelet
${SSH} core@${VM_IP} -- sudo systemctl disable kubelet nodeip-configuration
# Disable and stop kubelet and nodeip-configuration services
${SSH} core@${VM_IP} -- sudo systemctl disable --now kubelet nodeip-configuration


# Stop the kubelet service so it will not reprovision the pods
${SSH} core@${VM_IP} -- sudo systemctl stop kubelet
Expand Down Expand Up @@ -100,7 +100,6 @@ ${SSH} core@${VM_IP} 'sudo bash -x -s' <<EOF
cat > /etc/containers/systemd/gvisor-tap-vsock.container <<EOF1
[Unit]
Description=gvisor-tap-vsock
Before=nodeip-configuration.service

[Container]
Image=quay.io/crcont/gvisor-tap-vsock:latest
Expand Down