feat: static generated library #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duologic
commented
Jun 30, 2024
| + { | ||
| job+: { | ||
| steps:: {}, | ||
| step: (super.steps + { '#'+: { name: 'step' } }), |
There was a problem hiding this comment.
I just noticed that this doesn't work with the language server. 🤷
There was a problem hiding this comment.
Started a PR with testcases for this here: grafana/jsonnet-language-server#144
|
Have you found a use for jsonnet -> github actions workflows? I have made some fairly complex workflows in GHA and haven't found the need yet. The matrix feature is pretty powerful. Drone needed it because the matrix stuff was terrible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generates another static version of this library following the pattern I've used successfully in other libraries.
It doesn't include the
reusableWorkflowCallJobpart, not sure yet what that is used for. I'm new to GitHub Actions.The generator depends on crdsonnet/crdsonnet#24