Skip to content

Conversation

@Joyakis
Copy link
Contributor

@Joyakis Joyakis commented Nov 24, 2025

Fixes

Description

This pull request adds enhanced error handling in the shared file for opening data files in the reporting and processing scripts

Checklist

  • I have read and understood the Developer Certificate of Origin (DCO), below, which covers the contents of this pull request (PR).
  • My pull request doesn't include code or content generated with AI.
  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Joyakis Joyakis requested review from a team as code owners November 24, 2025 09:59
@Joyakis Joyakis requested review from TimidRobot and possumbilities and removed request for a team November 24, 2025 09:59
@Joyakis Joyakis changed the title Error handling Add Shared function to open data files Nov 24, 2025
@TimidRobot
Copy link
Member

@Joyakis This PR includes unrelated files related to wikicommons

Comment on lines 80 to 83
if not os.path.isfile(file_path):
raise QuantifyingException(
message=f"Data file not found: {file_path}", exit_code=1
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your handling isn't as problematic as #253, but splitting the logic between if and try/except (instead of just using try/except) makes me concerned.

Copy link
Contributor Author

@Joyakis Joyakis Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feedback! I understand your concern about splitting the logic between if and try/except. I can refactor it to fully use try/except for simplicity @TimidRobot

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have since updated it

@Joyakis
Copy link
Contributor Author

Joyakis commented Nov 24, 2025

@Joyakis This PR includes unrelated files related to wikicommons

Hello...I have removed the files

@TimidRobot TimidRobot self-assigned this Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

Add shared function to open data files and handle errors

2 participants