-
-
Notifications
You must be signed in to change notification settings - Fork 68
Add Shared function to open data files #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@Joyakis This PR includes unrelated files related to wikicommons |
scripts/shared.py
Outdated
| if not os.path.isfile(file_path): | ||
| raise QuantifyingException( | ||
| message=f"Data file not found: {file_path}", exit_code=1 | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your handling isn't as problematic as #253, but splitting the logic between if and try/except (instead of just using try/except) makes me concerned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the feedback! I understand your concern about splitting the logic between if and try/except. I can refactor it to fully use try/except for simplicity @TimidRobot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have since updated it
d1ed38d to
1a13e79
Compare
Hello...I have removed the files |
Fixes
Description
This pull request adds enhanced error handling in the shared file for opening data files in the reporting and processing scripts
Checklist
Update index.md).mainormaster).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin