fix: initialize string list before conditional in BraveSearchTool #473
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes UnboundLocalError that occurs when Brave Search API returns responses without a 'web' key.
Solution
Moves
string = []initialization outside the conditional block (before line 95), ensuring the variable is always defined before being referenced on line 112.Testing
Related
This defensive fix prevents crashes on empty/malformed API responses, allowing graceful error handling.
Note
Initialize
stringbefore the"web" in resultscheck to ensure it's defined even whenwebis absent.crewai_tools/tools/brave_search_tool/brave_search_tool.py):string = []before checking forresults["web"]and remove duplicate init inside the block, preventingUnboundLocalErrorwhenwebis missing.Written by Cursor Bugbot for commit 769914b. This will update automatically on new commits. Configure here.